Differential D15417

Convert Maniphest to curtain view
ClosedPublic
Actions

Authored by epriestley on Mar 6 2016, 6:16 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPeb1a0799ae8a: Convert Maniphest to curtain view

Summary

Moves Maniphest over, and allows application to provide ad-hoc panels more easily.

Test Plan

Screen Shot 2016-03-06 at 10.16.19 AM.png (1×1 px, 300 KB)

Diff Detail

Repository

rP Phabricator

Branch

2col6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11027
Build 13634: Run Core Tests
Build 13633: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37165.Mar 6 2016, 6:16 PM

epriestley retitled this revision from to Convert Maniphest to curtain view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

I was thinking of flipping Description to always be on top. I find it inconsistent to sometimes be on top and sometimes be after Details.

chad accepted this revision.Mar 6 2016, 6:30 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2016, 6:30 PM

Seems reasonable to me.

Closed by commit rPeb1a0799ae8a: Convert Maniphest to curtain view (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2016, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

80 lines

view/

layout/

PHUICurtainView.php

11 lines

Diff 37165

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php