Page MenuHomePhabricator
Differential D15402

Expand scope of addActionItem in PHUIHeaderView
ClosedPublic
Actions

Authored by chad on Mar 5 2016, 2:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 10:39 PM
Unknown Object (File)
Mon, Dec 23, 6:31 AM
Unknown Object (File)
Wed, Dec 18, 6:21 AM
Unknown Object (File)
Wed, Dec 18, 6:21 AM
Unknown Object (File)
Wed, Dec 18, 1:29 AM
Unknown Object (File)
Wed, Dec 18, 1:29 AM
Unknown Object (File)
Mon, Dec 9, 7:23 PM
Unknown Object (File)
Fri, Dec 6, 5:36 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10518: Adjustments to tags in HeaderView breaks workboard "point" tags
Commits
Restricted Diffusion Commit
rPfec1a154d54c: Expand scope of addActionItem in PHUIHeaderView
Summary

Gives a bit more flexibility to add anything to the right side of PHUIHeaderView.

Test Plan

Test Maniphest, Workboards, Project Home, Differential. Grep for addActionIcon use. Fixes T10518

Diff Detail

Repository
rP Phabricator
Branch
maniphest-boards (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10996
Build 13586: Run Core Tests
Build 13585: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37134.Mar 5 2016, 2:27 AM
chad retitled this revision from to Expand scope of addActionItem in PHUIHeaderView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10518: Adjustments to tags in HeaderView breaks workboard "point" tags.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 5 2016, 2:27 AM
epriestley accepted this revision.Mar 5 2016, 2:27 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2016, 2:27 AM
Closed by commit rPfec1a154d54c: Expand scope of addActionItem in PHUIHeaderView (authored by chad, committed by chad). · Explain WhyMar 5 2016, 2:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
conpherence/
controller/
2 lines
dashboard/
engine/
4 lines
paneltype/
2 lines
home/
controller/
2 lines
view/
phui/
18 lines
10 lines
webroot/
rsrc/
css/
phui/
5 lines
2 lines

Diff 37134

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

src/view/phui/PHUIWorkpanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility