Page MenuHomePhabricator
Differential D15394

Add headericons a little more consistently
ClosedPublic
Actions

Authored by chad on Mar 3 2016, 9:41 PM.
Tags
None
Referenced Files
F14386063: D15394.diff
Sat, Dec 21, 1:06 PM
Unknown Object (File)
Fri, Dec 20, 8:27 AM
Unknown Object (File)
Wed, Dec 18, 6:21 AM
Unknown Object (File)
Wed, Dec 18, 1:28 AM
Unknown Object (File)
Wed, Dec 18, 1:28 AM
Unknown Object (File)
Wed, Dec 18, 1:28 AM
Unknown Object (File)
Sat, Dec 14, 7:14 PM
Unknown Object (File)
Sat, Dec 14, 6:05 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPba5b32f5bb37: Add headericons a little more consistently
Summary

I kinda like these to differentiate the headers and different object types. Somethings duplicitive, but helps orient the clean header a bit.

Test Plan

Review each in sandbox.

Diff Detail

Repository
rP Phabricator
Branch
headericons (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10969
Build 13548: Run Core Tests
Build 13547: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37110.Mar 3 2016, 9:41 PM
chad retitled this revision from to Add headericons a little more consistently.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 3 2016, 9:41 PM
epriestley accepted this revision.Mar 3 2016, 10:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 10:07 PM
Closed by commit rPba5b32f5bb37: Add headericons a little more consistently (authored by chad, committed by chad). · Explain WhyMar 3 2016, 10:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
countdown/
controller/
3 lines
ponder/
controller/
1 line
slowvote/
controller/
3 lines

Diff 37110

View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
Phabricator · Built by Phacility