Page MenuHomePhabricator
Differential D15387

Update Calendar for PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 3 2016, 2:11 AM.
Tags
None
Referenced Files
F15504585: D15387.diff
Mon, Apr 14, 7:05 PM
F15489647: D15387.diff
Fri, Apr 11, 11:04 AM
F15485367: D15387.diff
Wed, Apr 9, 11:15 PM
F15438830: D15387.id37101.diff
Wed, Mar 26, 3:53 AM
F15438807: D15387.diff
Wed, Mar 26, 3:43 AM
F15420782: D15387.id37102.diff
Fri, Mar 21, 5:25 PM
F15411382: D15387.id37102.diff
Wed, Mar 19, 9:16 AM
F15394679: D15387.id.diff
Mar 16 2025, 12:01 AM
View All Files
Subscribers
• cedricabuso
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP61c45e4927a0: Update Calendar for PHUITwoColumnView
Summary

Moves calendar event view to PHUITwoColumnView. Tightened up some phui status spacing.

Test Plan

Review Calendar Events, Differential status list.

Diff Detail

Repository
rP Phabricator
Branch
calendar-two (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10958
Build 13530: Run Core Tests
Build 13529: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37101.Mar 3 2016, 2:11 AM
chad retitled this revision from to Update Calendar for PHUITwoColumnView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 3 2016, 2:11 AM
epriestley accepted this revision.Mar 3 2016, 2:11 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 2:11 AM
chad added inline comments.Mar 3 2016, 2:12 AM
webroot/rsrc/css/phui/phui-two-column-view.css
111

this property is so awesome!

Closed by commit rP61c45e4927a0: Update Calendar for PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 3 2016, 2:12 AM
This revision was automatically updated to reflect the committed changes.
• cedricabuso added a subscriber: • cedricabuso.Mar 3 2016, 8:50 AM

It works

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
128

THis is crazy

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
calendar/
controller/
83 lines
view/
phui/
11 lines
webroot/
rsrc/
css/
phui/
3 lines
2 lines

Diff 37101

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/view/phui/PHUIStatusItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-status.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility