Page MenuHomePhabricator
Differential D15378

Implement an iterator for build log chunks
ClosedPublic
Actions

Authored by epriestley on Mar 1 2016, 8:26 PM.
Tags
None
Referenced Files
F15394657: D15378.id37081.diff
Sat, Mar 15, 11:59 PM
F15394655: D15378.id.diff
Sat, Mar 15, 11:59 PM
F15394653: D15378.diff
Sat, Mar 15, 11:59 PM
F15394487: D15378.id37073.diff
Sat, Mar 15, 11:53 PM
F15388675: D15378.id37073.diff
Sat, Mar 15, 4:14 AM
F15377616: D15378.diff
Thu, Mar 13, 9:51 AM
Unknown Object (File)
Feb 15 2025, 10:27 AM
Unknown Object (File)
Feb 9 2025, 12:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5822: Implement garbage collection / automatic archiving for Harbormaster logs
Commits
Restricted Diffusion Commit
rP6514237c0e01: Implement an iterator for build log chunks
Summary

Ref T5822. This will make it easier to compress and archive chunks without needing to hold them in memory.

Test Plan

Ran a build, looked at some logs.

Diff Detail

Repository
rP Phabricator
Branch
dry17
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/storage/build/HarbormasterBuildLog.php:190XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 10930
Build 13489: Run Core Tests
Build 13488: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37073.Mar 1 2016, 8:26 PM
epriestley retitled this revision from to Implement an iterator for build log chunks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5822: Implement garbage collection / automatic archiving for Harbormaster logs.
chad accepted this revision.Mar 1 2016, 9:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 9:35 PM
Closed by commit rP6514237c0e01: Implement an iterator for build log chunks (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2016, 11:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
harbormaster/
storage/
build/
45 lines
23 lines
35 lines

Diff 37073

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLogChunk.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php

Loading...
Phabricator · Built by Phacility