Page MenuHomePhabricator

Slightly simplify the Harbormaster build log API
ClosedPublic

Authored by epriestley on Mar 1 2016, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 1:27 AM
Unknown Object (File)
Wed, Dec 18, 1:27 AM
Unknown Object (File)
Wed, Dec 18, 1:27 AM
Unknown Object (File)
Wed, Dec 18, 1:27 AM
Unknown Object (File)
Sun, Dec 8, 10:49 PM
Unknown Object (File)
Tue, Dec 3, 10:42 AM
Unknown Object (File)
Wed, Nov 27, 7:27 AM
Unknown Object (File)
Wed, Nov 27, 5:34 AM
Subscribers
None

Details

Summary

Ref T5822. This prepares for inline compression and garbage collection of build logs.

This reduces the API surface area and removes a log from the "wait" step that would just log a message every 15 seconds. (If this is actually useful, I think we find a better way to communicate it.)

Test Plan

Ran a build, saw a log:

Screen Shot 2016-03-01 at 6.55.22 AM.png (619×693 px, 72 KB)

Diff Detail

Repository
rP Phabricator
Branch
dry14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/storage/build/HarbormasterBuildLog.php:52XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 10903
Build 13455: Run Core Tests
Build 13454: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Slightly simplify the Harbormaster build log API.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 3:14 PM
This revision was automatically updated to reflect the committed changes.