Clover reports generated from PHPUnit sometimes give false positives of lines that were not covered by a test that should have actually been not coverable, apparently due to inaccurate static analysis of files that weren't actually executed. This filters coverage reports of files that show no coverage which avoids these false positives. Fixes T10420.
Details
Details
Looked at coverage reports of files before and after the change
Before:
After:
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- fix_clover_coverage (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10839 Build 13359: arc lint + arc unit
Event Timeline
Comment Actions
I added you to Blessed Committers if you want to arc land or "Land Revision" this yourself, or I can pull it if you hit issues (some of the "Land Revision" error reporting is particularly iffy, right now).