Differential D15337

Add a couple of missing needProperties() Almanac calls
ClosedPublic
Actions

Authored by epriestley on Feb 23 2016, 9:49 PM.

Details

Reviewers

chad

Maniphest Tasks

T10432: Attempting to access attached data on AlmanacBinding

Commits

Restricted Diffusion Commit
rPee6070a98492: Add a couple of missing needProperties() Almanac calls

Summary

Fixes T10432. I missed these in making properties non-default.

Test Plan

Diffusion now works again in a cluster configuration.

Diff Detail

Repository

rP Phabricator

Branch

almanac10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10828
Build 13344: Run Core Tests
Build 13343: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36988.Feb 23 2016, 9:49 PM

epriestley retitled this revision from to Add a couple of missing needProperties() Almanac calls.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10432: Attempting to access attached data on AlmanacBinding.

chad accepted this revision.Feb 23 2016, 9:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 23 2016, 9:50 PM

Closed by commit rPee6070a98492: Add a couple of missing needProperties() Almanac calls (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2016, 9:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryCreateController.php

1 line

repository/

storage/

PhabricatorRepository.php

1 line

Diff 36988

View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php