Page MenuHomePhabricator
Differential D15328

Restrict PropertyListView width to just DocumentProView
ClosedPublic
Actions

Authored by chad on Feb 22 2016, 7:50 PM.
Tags
None
Referenced Files
F14050104: D15328.diff
Thu, Nov 14, 4:33 PM
F14038709: D15328.diff
Mon, Nov 11, 1:34 AM
F14025147: D15328.diff
Thu, Nov 7, 2:45 PM
F13997177: D15328.diff
Thu, Oct 24, 2:51 AM
F13987238: D15328.id36970.diff
Mon, Oct 21, 8:15 AM
F13986626: D15328.id36971.diff
Mon, Oct 21, 4:22 AM
F13977095: D15328.id.diff
Oct 18 2024, 5:03 PM
Unknown Object (File)
Oct 3 2024, 10:38 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10409: Document-pro CSS rule is bleeding into Diffusion property lists
Commits
Restricted Diffusion Commit
rP023cfbb23af3: Restrict PropertyListView width to just DocumentProView
Summary

Fixes T10409. Long term need to build a proper "PageEngine" of sorts for layouts not needing special magic. For now this just affects a few applications.

Test Plan

View Diffusion, Phriction, Phame, Legalpad, Diviner.

Diff Detail

Repository
rP Phabricator
Branch
docu-bug-view (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10810
Build 13316: Run Core Tests
Build 13315: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36970.Feb 22 2016, 7:50 PM
chad retitled this revision from to Restrict PropertyListView width to just DocumentProView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10409: Document-pro CSS rule is bleeding into Diffusion property lists.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 22 2016, 7:50 PM
epriestley accepted this revision.Feb 22 2016, 7:50 PM
epriestley edited edge metadata.

kewl thx :3

This revision is now accepted and ready to land.Feb 22 2016, 7:50 PM
Closed by commit rP023cfbb23af3: Restrict PropertyListView width to just DocumentProView (authored by chad, committed by chad). · Explain WhyFeb 22 2016, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
diviner/
controller/
2 lines
phame/
controller/
post/
1 line
phriction/
controller/
1 line
webroot/
rsrc/
css/
application/
phame/
3 lines
phui/
13 lines

Diff 36970

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Phabricator · Built by Phacility