Page MenuHomePhabricator

Rough-in Almanac namespaces
ClosedPublic

Authored by epriestley on Feb 21 2016, 10:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Fri, Dec 6, 1:38 AM
Unknown Object (File)
Thu, Dec 5, 10:41 AM
Unknown Object (File)
Thu, Dec 5, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 8:17 PM
Subscribers
None

Details

Summary

Ref T6741. Ref T10246.

Root problem: to provide Drydock in the cluster, we need to expose Almanac, and doing so would let users accidentally or intentionally create a bunch of repo006.phacility.net devices/services which could conflict with the real ones we manage.

There's currently no way to say "you can't create anything named *.blah.net". This adds "namespaces", which let you do that (well, not yet, but they will after the next diff).

After the next diff, if you try to create repo003.phacility.net, but the namespace phacility.net already exists and you don't have permission to edit it, you'll be asked to choose a different name.

Also various modernizations and some new docs.

Test Plan
  • Created cool namespaces like this.computer.
  • Almanac namespaces don't actually enforce policies yet.

Diff Detail

Repository
rP Phabricator
Branch
almanac5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10797
Build 13296: Run Core Tests
Build 13295: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Rough-in Almanac namespaces.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/almanac/util/AlmanacNames.php
44

Almanac

This revision is now accepted and ready to land.Feb 22 2016, 6:45 AM
epriestley edited edge metadata.
  • Fix "Almacaaca". grep found a bonus one, too!
This revision was automatically updated to reflect the committed changes.