Paths

Table of Contentst

Differential D15311

Always install the "icon" and "emoji" remarkup rules
ClosedPublic
Actions

Authored by epriestley on Feb 19 2016, 7:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T10394: Font awesome icons not rendering in remarkup on Phacility

Commits

Restricted Diffusion Commit
rP50f910ce67ac: Always install the "icon" and "emoji" remarkup rules

Summary

Ref T10394. Currently, these rules are only active if the Macro application is installed. Instead, install them unconditionally.

Test Plan

Used {icon camera} with Macro installed and uninstalled.

Diff Detail

Repository

rP Phabricator

Branch

iconrule

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10776
Build 13266: Run Core Tests
Build 13265: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36933.Feb 19 2016, 7:44 PM

epriestley retitled this revision from to Always install the "icon" and "emoji" remarkup rules.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10394: Font awesome icons not rendering in remarkup on Phacility.

epriestley mentioned this in T10394: Font awesome icons not rendering in remarkup on Phacility.Feb 19 2016, 7:45 PM

chad accepted this revision.Feb 19 2016, 7:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 19 2016, 7:46 PM

Closed by commit rP50f910ce67ac: Always install the "icon" and "emoji" remarkup rules (authored by epriestley, committed by epriestley). · Explain WhyFeb 19 2016, 7:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

application/

PhabricatorMacroApplication.php

7 lines

infrastructure/

markup/

PhabricatorMarkupEngine.php

3 lines

Diff 36933

View Options

src/applications/macro/application/PhabricatorMacroApplication.php