Page MenuHomePhabricator
Differential D15288

Add ability to setActionList to a PHUIHeaderView
ClosedPublic
Actions

Authored by chad on Feb 17 2016, 3:57 AM.
Tags
None
Referenced Files
F13196273: D15288.diff
Sun, May 12, 11:08 PM
Unknown Object (File)
Mon, May 6, 6:44 AM
Unknown Object (File)
Fri, May 3, 3:39 AM
Unknown Object (File)
Mon, Apr 29, 3:40 PM
Unknown Object (File)
Thu, Apr 25, 10:24 PM
Unknown Object (File)
Wed, Apr 24, 11:40 PM
Unknown Object (File)
Apr 11 2024, 6:17 PM
Unknown Object (File)
Apr 11 2024, 7:57 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP8c3ca2a72971: Add ability to setActionList to a PHUIHeaderView
Summary

We're using this a little more, so I'd prefer less copy-pasta and one place to manage the UI. Maybe add a caret?

Test Plan

grep for 'Actions', test Phriction, Diviner, ect, Action Menus.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36883.Feb 17 2016, 3:57 AM
chad retitled this revision from to Add ability to setActionList to a PHUIHeaderView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 17 2016, 3:57 AM
epriestley accepted this revision.Feb 17 2016, 3:59 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2016, 3:59 AM
Closed by commit rP8c3ca2a72971: Add ability to setActionList to a PHUIHeaderView (authored by chad, committed by chad). · Explain WhyFeb 17 2016, 4:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
controller/
10 lines
phame/
controller/
blog/
11 lines
post/
11 lines
phriction/
controller/
10 lines
view/
phui/
17 lines

Diff 36884

View Options

src/applications/diviner/controller/DivinerBookController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
Phabricator · Built by Phacility