Page MenuHomePhabricator
Differential D15283

Add Workboard UI Color to sidenav, fix fullscreen CSS
ClosedPublic
Actions

Authored by chad on Feb 16 2016, 10:24 PM.
Tags
None
Referenced Files
F14494052: D15283.diff
Fri, Jan 3, 4:22 AM
F14492278: D15283.id36874.diff
Thu, Jan 2, 5:44 PM
Unknown Object (File)
Tue, Dec 31, 4:53 PM
Unknown Object (File)
Wed, Dec 25, 4:13 AM
Unknown Object (File)
Mon, Dec 23, 12:46 AM
Unknown Object (File)
Mon, Dec 23, 12:45 AM
Unknown Object (File)
Mon, Dec 23, 12:45 AM
Unknown Object (File)
Sun, Dec 22, 10:03 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP71be2b06a8ea: Add Workboard UI Color to sidenav, fix fullscreen CSS
Summary

Uses the background color changes to show also on the side nav. Places color on entire body so fullscreen doesn't show other body color.

Test Plan

Review various workboard colors at normal and fullscreen

Diff Detail

Repository
rP Phabricator
Branch
workboard-colors-3 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10720
Build 13181: Run Core Tests
Build 13180: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36874.Feb 16 2016, 10:24 PM
chad retitled this revision from to Add Workboard UI Color to sidenav, fix fullscreen CSS.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 16 2016, 10:24 PM
chad updated this revision to Diff 36876.Feb 16 2016, 10:28 PM
  • Clean up some text colors
epriestley accepted this revision.Feb 16 2016, 10:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2016, 10:28 PM
Closed by commit rP71be2b06a8ea: Add Workboard UI Color to sidenav, fix fullscreen CSS (authored by chad, committed by chad). · Explain WhyFeb 16 2016, 10:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
project/
controller/
2 lines
webroot/
rsrc/
css/
phui/
9 lines
workboards/
12 lines

Diff 36876

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-profile-menu.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

Loading...
Phabricator · Built by Phacility