Page MenuHomePhabricator
Differential D15281

Update to use PHUIRemarkupView everywhere possible
ClosedPublic
Actions

Authored by chad on Feb 16 2016, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 2:25 AM
Unknown Object (File)
Thu, Dec 19, 6:06 AM
Unknown Object (File)
Sun, Dec 15, 11:52 AM
Unknown Object (File)
Thu, Dec 5, 11:16 AM
Unknown Object (File)
Tue, Dec 3, 3:45 AM
Unknown Object (File)
Fri, Nov 29, 9:57 AM
Unknown Object (File)
Nov 20 2024, 9:28 PM
Unknown Object (File)
Nov 20 2024, 10:36 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPf35509e30ee7: Update to use PHUIRemarkupView everywhere possible
Summary

Moves all the one off object calls to PHUIRemarkupView, adds a "Document" call as well (future plans).

Test Plan

Visited most pages I could get access to, but may want extra careful eyes on this diff.

Diff Detail

Repository
rP Phabricator
Branch
PHUIRemarkupView (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10714
Build 13171: Run Core Tests
Build 13170: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36869.Feb 16 2016, 9:45 PM
chad retitled this revision from to Update to use PHUIRemarkupView everywhere possible.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 16 2016, 9:45 PM
epriestley accepted this revision.Feb 16 2016, 9:50 PM
epriestley edited edge metadata.

Caught one issue, see inline.

src/view/form/AphrontFormView.php
88–89

I think this one is wrong, and lost an appendInstructions(...) call.

This revision is now accepted and ready to land.Feb 16 2016, 9:50 PM
chad updated this revision to Diff 36870.Feb 16 2016, 9:53 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • comment
Closed by commit rPf35509e30ee7: Update to use PHUIRemarkupView everywhere possible (authored by chad, committed by chad). · Explain WhyFeb 16 2016, 10:05 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Feb 16 2016, 10:05 PM

here goes nothing.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
6 lines
config/
controller/
30 lines
countdown/
controller/
6 lines
differential/
customfield/
7 lines
7 lines
7 lines
diffusion/
controller/
5 lines
5 lines
diviner/
controller/
6 lines
6 lines
doorkeeper/
option/
10 lines
fund/
controller/
12 lines
harbormaster/
controller/
10 lines
legalpad/
controller/
6 lines
meta/
controller/
9 lines
5 lines
nuance/
source/
6 lines
owners/
controller/
7 lines
phame/
controller/
blog/
5 lines
pholio/
controller/
7 lines
phortune/
controller/
7 lines
6 lines
phurl/
controller/
10 lines
slowvote/
controller/
14 lines
view/
10 lines
spaces/
controller/
7 lines
transactions/
controller/
5 lines
typeahead/
controller/
6 lines
uiexample/
examples/
5 lines
infrastructure/
customfield/
standard/
7 lines
markup/
view/
21 lines
view/
form/
6 lines
9 lines
7 lines

Diff 36870

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialRevertPlanField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialSummaryField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialTestPlanField.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
View Options

src/applications/diviner/controller/DivinerBookController.php

Loading...
View Options

src/applications/diviner/controller/DivinerMainController.php

Loading...
View Options

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

Loading...
View Options

src/applications/fund/controller/FundInitiativeViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

Loading...
View Options

src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogManageController.php

Loading...
View Options

src/applications/pholio/controller/PholioInlineController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneMerchantViewController.php

Loading...
View Options

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
View Options

src/applications/spaces/controller/PhabricatorSpacesViewController.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRawController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorRemarkupUIExample.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

Loading...
View Options

src/infrastructure/markup/view/PHUIRemarkupView.php

Loading...
View Options

src/view/form/AphrontFormView.php

Loading...
View Options

src/view/form/PHUIFormLayoutView.php

Loading...
View Options

src/view/form/PHUIFormPageView.php

Loading...
Phabricator · Built by Phacility