Differential D15280

Make subproject/milestone watch rules work better
ClosedPublic
Actions

Authored by epriestley on Feb 16 2016, 6:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 7:20 PM

	Unknown Object (File)
	Tue, Jan 28, 5:26 PM

	Unknown Object (File)
	Sun, Jan 26, 6:06 PM

	Unknown Object (File)
	Wed, Jan 22, 2:14 AM

	Unknown Object (File)
	Sun, Jan 19, 9:55 PM

	Unknown Object (File)
	Mon, Jan 13, 8:11 AM

	Unknown Object (File)
	Fri, Jan 10, 10:15 PM

	Unknown Object (File)
	Wed, Jan 8, 12:52 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10349: Projects v3 Errata

Commits

Restricted Diffusion Commit
rP376c85a828c8: Make subproject/milestone watch rules work better

Summary

Ref T10349. These got sort of half-weirded-up before I separated subscriptions and watching fully. New rules are:

You can watch whatever you want.
Watching a parent watches everything inside it.
If you're watching "Stonework" and go to "Stonework > Masonry", you'll see a "Watching Ancestor" hint to let you know you're already watching a parent or ancestor.

Test Plan

Watched and unwatched "Stonework".
Watched and unwatched "Stonework > Iteration IV".
While watching "Stonework", visited "Iteration IV" and saw "Watching Ancestor" hint.
Created a task tagged "Stonework > Iteration IV". Got notified about it because I watch "Stonework".

Diff Detail

Repository

Branch

awatcher

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10710
Build 13164: Run Core Tests
Build 13163: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36866.Feb 16 2016, 6:33 PM

epriestley retitled this revision from to Make subproject/milestone watch rules work better.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10349: Projects v3 Errata.

epriestley added inline comments.Feb 16 2016, 6:34 PM

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php
31	This was leftover from when Projects could be subscribed to.

Ancestor seems a bit technical... but I can't think of anything better. Maybe put the project name in the dialog?

This revision is now accepted and ready to land.Feb 16 2016, 6:36 PM

Show which ancestor is watched.

Screen Shot 2016-02-16 at 10.40.06 AM.png (189×572 px, 20 KB)

Closed by commit rP376c85a828c8: Make subproject/milestone watch rules work better (authored by epriestley, committed by epriestley). · Explain WhyFeb 16 2016, 6:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectProfileController.php

22 lines

PhabricatorProjectWatchController.php

29 lines

query/

PhabricatorProjectQuery.php

12 lines

storage/

PhabricatorProject.php

28 lines

subscriptions/

controller/

PhabricatorSubscriptionsEditController.php

22 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

19 lines

Diff 36866

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/project/controller/PhabricatorProjectWatchController.php

Loading...

src/applications/project/query/PhabricatorProjectQuery.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...