Page MenuHomePhabricator
Differential D15269

Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds
ClosedPublic
Actions

Authored by chad on Feb 13 2016, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 13, 3:42 PM
Unknown Object (File)
Thu, Oct 10, 6:46 AM
Unknown Object (File)
Mon, Oct 7, 6:23 AM
Unknown Object (File)
Wed, Oct 2, 7:03 AM
Unknown Object (File)
Wed, Oct 2, 7:03 AM
Unknown Object (File)
Wed, Oct 2, 7:03 AM
Unknown Object (File)
Wed, Oct 2, 6:48 AM
Unknown Object (File)
Mon, Sep 30, 3:23 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPc1f57605ab34: Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds
Summary

Cleans up the backgrounds a little on Projects/Profiles and adds a number of colour choices for Workboards.

Test Plan

Manually add each color for testing. Test new project / profile layouts with and without properties.

Screen Shot 2016-02-13 at 12.01.03 PM.png (1×2 px, 471 KB)

Screen Shot 2016-02-13 at 9.16.27 AM.png (1×2 px, 1 MB)

Screen Shot 2016-02-13 at 12.00.56 PM.png (1×2 px, 540 KB)

Screen Shot 2016-02-13 at 7.47.51 AM.png (1×2 px, 1 MB)

Diff Detail

Repository
rP Phabricator
Branch
profile-tweaks (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/project/controller/PhabricatorProjectBoardViewController.php:430XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 10686
Build 13128: Run Core Tests
Build 13127: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36842.Feb 13 2016, 7:59 PM
chad retitled this revision from to Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 13 2016, 7:59 PM
chad edited the test plan for this revision. (Show Details)Feb 13 2016, 8:04 PM
epriestley accepted this revision.Feb 13 2016, 8:07 PM
epriestley edited edge metadata.

Cool, I'll wire these up in a bit.

This revision is now accepted and ready to land.Feb 13 2016, 8:07 PM
Closed by commit rPc1f57605ab34: Normalize colors a bit better on Profiles/Projects, add Workboard backgrounds (authored by chad, committed by chad). · Explain WhyFeb 13 2016, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
src/
applications/
people/
controller/
2 lines
project/
controller/
5 lines
2 lines
webroot/
rsrc/
css/
application/
project/
29 lines
phui/
20 lines
8 lines
1 line
workboards/
88 lines
2 lines
3 lines

Diff 36842

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

webroot/rsrc/css/application/project/project-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-box.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workpanel.css

Loading...
Phabricator · Built by Phacility