Page MenuHomePhabricator
Differential D15266

Sort milestones by milestone number, not ID
ClosedPublic
Actions

Authored by epriestley on Feb 13 2016, 4:29 PM.
Tags
None
Referenced Files
F14053417: D15266.id36838.diff
Fri, Nov 15, 3:36 PM
Unknown Object (File)
Oct 9 2024, 3:10 AM
Unknown Object (File)
Sep 20 2024, 11:32 PM
Unknown Object (File)
Sep 18 2024, 8:44 AM
Unknown Object (File)
Sep 1 2024, 4:04 PM
Unknown Object (File)
Sep 1 2024, 4:03 PM
Unknown Object (File)
Sep 1 2024, 4:02 PM
Unknown Object (File)
Aug 31 2024, 6:57 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10350: Scripts to migrate old "points" fields and move projects beneath other projects
Commits
Restricted Diffusion Commit
rP9bab3c25b83d: Sort milestones by milestone number, not ID
Summary

Ref T10350. Normally, milestone numbers and IDs have the same order, but they may not if you used the script in T10350 to artificially move a bunch of stuff around.

Test Plan

Milestones now go "1, 2, <thing I artifically moved into position 3>" on local install.

Diff Detail

Repository
rP Phabricator
Branch
msort
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10680
Build 13119: Run Core Tests
Build 13118: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36836.Feb 13 2016, 4:29 PM
epriestley retitled this revision from to Sort milestones by milestone number, not ID.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10350: Scripts to migrate old "points" fields and move projects beneath other projects.
chad accepted this revision.Feb 13 2016, 4:30 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 13 2016, 4:30 PM
Closed by commit rP9bab3c25b83d: Sort milestones by milestone number, not ID (authored by epriestley, committed by epriestley). · Explain WhyFeb 13 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

Diff 36836

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
Phabricator · Built by Phacility