Page MenuHomePhabricator

Don't show un-completeable results in people/project autocomplete
ClosedPublic

Authored by epriestley on Feb 12 2016, 5:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 6:28 AM
Unknown Object (File)
Apr 14 2025, 1:05 PM
Unknown Object (File)
Apr 14 2025, 6:15 AM
Unknown Object (File)
Apr 7 2025, 8:20 AM
Unknown Object (File)
Mar 23 2025, 7:00 AM
Unknown Object (File)
Mar 15 2025, 11:57 PM
Unknown Object (File)
Mar 15 2025, 11:47 PM
Unknown Object (File)
Mar 15 2025, 11:47 PM
Subscribers
None

Details

Summary

Fixes T10285.

  • If a result (like a milestone) has no primary hashtag, try to fill in a secondary hashtag.
  • If we can't find any hashtag, don't return the result.

This produces these behaviors:

  • By default, you can't autocomplete milestones.
  • If you give one a hashtag, you can.

We might want to give milestones "special" hashtags eventually (like #xyz/33) but this fixes the confusing/broken behavior in the UI and we can wait for a better use case for letting you autocomplete milestones, I think.

Also, don't try to cycle hashtags when renaming milestones. This was a little inconsistent before.

Test Plan
  • Autocompleted normal projects.
  • Autocompleted milestones with explicit hashtags.
  • No autocomplete entry for milestones with no special hashtags.
  • Used normal typeahead to get tag-less milestones to make sure I didn't break anything.

Diff Detail

Repository
rP Phabricator
Branch
typeahead
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10668
Build 13102: Run Core Tests
Build 13101: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't show un-completeable results in people/project autocomplete.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2016, 6:00 PM
This revision was automatically updated to reflect the committed changes.