Mimics the Project Hovercards, more custom UI.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP6ae0a62f9f48: New People Hovercards
Hover over person with and without badges, hover over project.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- people-hovercards (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10649 Build 13074: Run Core Tests Build 13073: arc lint + arc unit
Event Timeline
| src/applications/people/engineextension/PeopleHovercardEngineExtension.php | ||
|---|---|---|
| 33 | Mostly for completeness: we could load badges here to possibly save a few queries, but I'm pretty sure we never actually bulk-render hovercards right now. But if we swap to a system where you can "View Results As: Hovecards" or have dashboards panels or something like that on list views, we should clean this up if we remember. Probably we won't, but I'll catch it on an XHProf profile and remember writing this inline and then know where to look to fix it. | |
| src/applications/people/view/PhabricatorUserCardView.php | ||
| 19–22 | (Do we need this? Big plans?) | |
| src/applications/people/view/PhabricatorUserCardView.php | ||
|---|---|---|
| 19–22 | This is if we render the card directly on a page, it can be wrapped in an anchor instead of a div. I also used it for testing. | |