Differential D15240

Don't adjust task priority after a workboard drag unless we need to
ClosedPublic
Actions

Authored by epriestley on Feb 10 2016, 11:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T8197: Dropping workboard cards on the bottom of a priority column is buggy

Commits

Restricted Diffusion Commit
rP968ac764532d: Don't adjust task priority after a workboard drag unless we need to

Summary

Fixes T8197. Currently, if you priority-sort a workboard and drag a card to the top or bottom, we change the priority even if we do not need to.

For example, if the lowest priority in a column is "Low", and you drag a "Wishlist" task underneath it, we incorrectly increase the priority of the task to "Low", when we do not actually need to touch it. This is bad/confusing.

A similar thing happens when dragging a "High" priority task to the top of a column where the highest priority is currently "Normal".

Test Plan

Create a column with a "Normal" task.
Sort workboard by Priority.
Drag a "High" task above it. After patch: task still "High".
Drag a "Wishlist" task below it. After patch: task still "Wishlist".

Also dragged a ton of tasks into the middle of other tasks.

Diff Detail

Repository

rP Phabricator

Branch

board20

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10626
Build 13040: Run Core Tests
Build 13039: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36784.Feb 10 2016, 11:45 PM

epriestley retitled this revision from to Don't adjust task priority after a workboard drag unless we need to.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8197: Dropping workboard cards on the bottom of a priority column is buggy.

chad accepted this revision.Feb 10 2016, 11:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2016, 11:46 PM

Closed by commit rP968ac764532d: Don't adjust task priority after a workboard drag unless we need to (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2016, 12:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTask.php

33 lines

project/

controller/

PhabricatorProjectMoveController.php

149 lines

Diff 36784

View Options

src/applications/maniphest/storage/ManiphestTask.php