Page MenuHomePhabricator

Rewrite workboards to have way more bugs
ClosedPublic

Authored by epriestley on Feb 10 2016, 6:45 PM.
Tags
None
Referenced Files
F14003400: D15234.id36764.diff
Sat, Oct 26, 5:54 AM
F13996303: D15234.id36774.diff
Wed, Oct 23, 7:58 PM
F13988140: D15234.id.diff
Mon, Oct 21, 1:25 PM
F13968109: D15234.id36764.diff
Oct 16 2024, 6:41 PM
F13968108: D15234.id36763.diff
Oct 16 2024, 6:41 PM
F13965242: D15234.id36763.diff
Oct 16 2024, 12:49 AM
Unknown Object (File)
Oct 10 2024, 2:17 AM
Unknown Object (File)
Oct 9 2024, 3:10 AM
Subscribers
None

Details

Summary

Ref T4900. Briefly:

  • Much more layout and rendering is now done in Javascript.
  • This should otherwise be identical to the behavior at HEAD, except that:
    • editing a task and removing the current board from it no longer removes the task; and
    • points still don't work.

However, this can now plausibly support realtime workboard updates and other complex state-based behaviors like points calculations in a future change.

Test Plan
  • Changed card covers.
  • Moved cards.
  • Sorted board by priority and natural.
  • Added new cards.
  • Edited cards in place.

Diff Detail

Repository
rP Phabricator
Branch
board17
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/projects/WorkboardBoard.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 10606
Build 13013: Run Core Tests
Build 13012: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Rewrite workboards to have way more bugs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Slightly smaller/cleaner diff.
chad edited edge metadata.
chad added inline comments.
src/applications/project/view/ProjectBoardTaskCard.php
114

I feel like we should move this into PHUIObjectItemView as a setType or something?

This revision is now accepted and ready to land.Feb 10 2016, 7:10 PM

It's only in one place now (sort of) so I'm not too worried about it.

This revision was automatically updated to reflect the committed changes.