Page MenuHomePhabricator

Use passthru to run `git fetch` in `arc land` so password prompts work
ClosedPublic

Authored by epriestley on Feb 10 2016, 2:24 PM.
Tags
None
Referenced Files
F15196603: D15233.id36761.diff
Sat, Feb 22, 6:11 PM
Unknown Object (File)
Sun, Feb 9, 12:43 AM
Unknown Object (File)
Sun, Feb 9, 12:43 AM
Unknown Object (File)
Sun, Feb 9, 12:43 AM
Unknown Object (File)
Tue, Jan 28, 2:21 PM
Unknown Object (File)
Fri, Jan 24, 11:44 AM
Unknown Object (File)
Fri, Jan 24, 11:44 AM
Unknown Object (File)
Fri, Jan 24, 11:44 AM
Subscribers

Details

Summary

Fixes T10314. In arc land, we currently run git fetch as a subprocess.

However, this can prevent password prompts (when fetching over HTTP with basic authentication) from working properly.

Instead, use passthru to redirect stdin/stdout to the subprocess so the user can type their password.

This adds a little extra clutter to the arc land output but I think that's OK.

Test Plan

See T10314, @maxie confirmed this fixes the issue.

Diff Detail

Repository
rARC Arcanist
Branch
httpfetch
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10603
Build 13008: Run Core Tests
Build 13007: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use passthru to run `git fetch` in `arc land` so password prompts work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: maxie.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.