Differential D15188

Slightly better spacing, colors on ProjectCards
ClosedPublic
Actions

Authored by chad on Feb 5 2016, 6:28 PM.

Tags

None

Referenced Files

	F14831140: D15188.id36667.diff
	Wed, Jan 29, 11:47 PM

	Unknown Object (File)
	Wed, Jan 29, 3:43 AM

	Unknown Object (File)
	Sun, Jan 26, 8:19 AM

	Unknown Object (File)
	Sun, Jan 26, 6:08 AM

	Unknown Object (File)
	Tue, Jan 21, 3:56 PM

	Unknown Object (File)
	Tue, Jan 21, 12:51 PM

	Unknown Object (File)
	Sat, Jan 18, 1:00 AM

	Unknown Object (File)
	Wed, Jan 1, 9:06 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP8e7e999cc34b: Slightly better spacing, colors on ProjectCards

Summary

Fixes transparent background images, removes "checkered". Better spacing for tags.

Test Plan

Upload a transparent logo, hover over project.

pasted_file (298×504 px, 42 KB)

Diff Detail

Repository

Branch

proj-cards-2 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10506
Build 12859: Run Core Tests
Build 12858: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	170 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 308 Passed)

Event Timeline

chad updated this revision to Diff 36666.Feb 5 2016, 6:28 PM

chad retitled this revision from to Slightly better spacing, colors on ProjectCards.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 5 2016, 6:28 PM

chad edited the test plan for this revision. (Show Details)Feb 5 2016, 6:29 PM

epriestley accepted this revision.Feb 5 2016, 6:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 5 2016, 6:29 PM

re-run celerity

Closed by commit rP8e7e999cc34b: Slightly better spacing, colors on ProjectCards (authored by chad, committed by chad). · Explain WhyFeb 5 2016, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

27 lines

webroot/

rsrc/

css/

application/

project/

project-card-view.css

42 lines

Diff 36666

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/project/project-card-view.css

Loading...