Page MenuHomePhabricator
Differential D15187

Add icon / grey text when task is closed on workboards
ClosedPublic
Actions

Authored by chad on Feb 5 2016, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 5:34 PM
Unknown Object (File)
Fri, Jan 24, 11:37 AM
Unknown Object (File)
Fri, Jan 24, 11:37 AM
Unknown Object (File)
Fri, Jan 24, 11:37 AM
Unknown Object (File)
Fri, Jan 24, 11:37 AM
Unknown Object (File)
Fri, Jan 24, 11:37 AM
Unknown Object (File)
Fri, Jan 24, 5:49 AM
Unknown Object (File)
Fri, Jan 24, 1:27 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10281: in workboard, open and closed tickets are now too visually similar
Commits
Restricted Diffusion Commit
rPb9585f29fa29: Add icon / grey text when task is closed on workboards
Summary

Fixes T10281. Adds the closed icon (resolved, dupe, ect) as an attribute and makes the text grey again.

Test Plan

View workboard with "All Tasks"

pasted_file (530×325 px, 52 KB)

Diff Detail

Repository
rP Phabricator
Branch
disabled-task (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10501
Build 12852: Run Core Tests
Build 12851: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36661.Feb 5 2016, 5:55 AM
chad retitled this revision from to Add icon / grey text when task is closed on workboards.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10281: in workboard, open and closed tickets are now too visually similar.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 5 2016, 5:55 AM
chad updated this revision to Diff 36662.Feb 5 2016, 6:08 AM
  • make bar grey too
chad edited the test plan for this revision. (Show Details)Feb 5 2016, 6:13 AM
epriestley accepted this revision.Feb 5 2016, 3:55 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2016, 3:55 PM
Closed by commit rPb9585f29fa29: Add icon / grey text when task is closed on workboards (authored by chad, committed by chad). · Explain WhyFeb 5 2016, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
project/
view/
7 lines
webroot/
rsrc/
css/
phui/
workboards/
4 lines

Diff 36661

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/view/ProjectBoardTaskCard.php

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...
Phabricator · Built by Phacility