Page MenuHomePhabricator
Differential D15179

Fix mishandling of chunk threshold in Diffusion for installs with no chunk engines available
ClosedPublic
Actions

Authored by epriestley on Feb 3 2016, 10:45 PM.
Tags
None
Referenced Files
F15414173: D15179.id36638.diff
Wed, Mar 19, 11:17 PM
F15409043: D15179.id36639.diff
Wed, Mar 19, 3:02 AM
F15402313: D15179.id.diff
Mon, Mar 17, 9:55 PM
F15394959: D15179.id36638.diff
Sun, Mar 16, 2:33 AM
F15383685: D15179.id36638.diff
Fri, Mar 14, 5:34 PM
F15375589: D15179.id36638.diff
Wed, Mar 12, 11:34 PM
F15335860: D15179.id36638.diff
Sat, Mar 8, 5:38 PM
F15315743: D15179.diff
Thu, Mar 6, 6:08 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception.
Commits
Restricted Diffusion Commit
rP68254a046ff0: Fix mishandling of chunk threshold in Diffusion for installs with no chunk…
Summary

Fixes T10273. The threshold is null if no chunk engines are available, but the code didn't handle this properly.

Test Plan

Disabled all chunk engines, reloaded, hit issue described in task. Applied patch, got clean file content.

Diff Detail

Repository
rP Phabricator
Branch
chunk1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10478
Build 12819: Run Core Tests
Build 12818: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36638.Feb 3 2016, 10:45 PM
epriestley retitled this revision from to Fix mishandling of chunk threshold in Diffusion for installs with no chunk engines available.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..
chad accepted this revision.Feb 3 2016, 10:46 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2016, 10:46 PM
Closed by commit rP68254a046ff0: Fix mishandling of chunk threshold in Diffusion for installs with no chunk… (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2016, 10:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
uploadsource/
30 lines

Diff 36638

View Options

src/applications/files/uploadsource/PhabricatorFileUploadSource.php

Loading...
Phabricator · Built by Phacility