Differential D15177

Remove old position-on-read board column code
ClosedPublic
Actions

Authored by epriestley on Feb 3 2016, 8:14 PM.

Details

Reviewers

chad

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rP9961de0e809a: Remove old position-on-read board column code

Summary

Ref T10010. This retires the old way of doing things inside ColumnPositionQuery. It is now obsolete and lives in BoardLayoutEngine instead.

Test Plan

Moved cards, created cards, swapped filters, orders, etc.
Some degree of unit testing coming in the next diff.

Diff Detail

Repository

rP Phabricator

Branch

col5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10476
Build 12815: Run Core Tests
Build 12814: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36636.Feb 3 2016, 8:14 PM

epriestley retitled this revision from to Remove old position-on-read board column code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

≧☉_☉≦
≧☉_☉≦
≧☉_☉≦
≧☉_☉≦
≧☉_☉≦

This revision is now accepted and ready to land.Feb 3 2016, 8:36 PM

Closed by commit rP9961de0e809a: Remove old position-on-read board column code (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2016, 11:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestEditEngine.php

3 lines

project/

query/

PhabricatorProjectColumnPositionQuery.php

255 lines

Diff 36636

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php