Differential D15176

Nearly complete lifting card-move code out of workboards
ClosedPublic
Actions

Authored by epriestley on Feb 3 2016, 8:03 PM.

Details

Reviewers

chad

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rPe25a40236fe2: Nearly complete lifting card-move code out of workboards

Summary

Ref T10010. This gets rid of the last dependency on the weird ColumnPositionQuery code.

Test Plan

Viewed workboards.
Used batch editor.
Created a new workboard.
Dragged stuff around.
Created new tasks into columns.
Changed order from natural to priority, dragged things around.
Switched filter to custom filter, "all tasks", etc.

Diff Detail

Repository

rP Phabricator

Branch

col4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10475
Build 12813: Run Core Tests
Build 12812: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36635.Feb 3 2016, 8:03 PM

epriestley retitled this revision from to Nearly complete lifting card-move code out of workboards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

chad accepted this revision.Feb 3 2016, 8:30 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2016, 8:30 PM

Closed by commit rPe25a40236fe2: Nearly complete lifting card-move code out of workboards (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2016, 11:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

175 lines

engine/

PhabricatorBoardLayoutEngine.php

22 lines

Diff 36635

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php