Page MenuHomePhabricator
Differential D15170

Flip layout on PhameHome
ClosedPublic
Actions

Authored by chad on Feb 2 2016, 10:47 PM.
Tags
None
Referenced Files
F15440383: D15170.id.diff
Wed, Mar 26, 12:32 PM
F15439992: D15170.diff
Wed, Mar 26, 10:39 AM
F15414171: D15170.id.diff
Wed, Mar 19, 11:17 PM
F15394957: D15170.id.diff
Sun, Mar 16, 2:33 AM
F15388271: D15170.id36624.diff
Sat, Mar 15, 3:34 AM
F15375587: D15170.id.diff
Wed, Mar 12, 11:34 PM
F15335858: D15170.id.diff
Sat, Mar 8, 5:38 PM
F15331748: D15170.diff
Fri, Mar 7, 1:21 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP95af3624d754: Flip layout on PhameHome
Summary

Centers the page for consistency for the rest of Phame, puts blog list on right for better mobile support.

Test Plan

Review PhameHome at all breakpoints.

Diff Detail

Repository
rP Phabricator
Branch
phame-home-4 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10464
Build 12794: Run Core Tests
Build 12793: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36624.Feb 2 2016, 10:47 PM
chad retitled this revision from to Flip layout on PhameHome.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 2 2016, 10:47 PM
chad added a comment.Feb 2 2016, 10:50 PM

Semi tempted to attempt a profilePanel, but no idea how easy/hard they are to build into a new app.

epriestley accepted this revision.Feb 2 2016, 11:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2016, 11:06 PM
Closed by commit rP95af3624d754: Flip layout on PhameHome (authored by chad, committed by chad). · Explain WhyFeb 2 2016, 11:11 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Feb 2 2016, 11:12 PM

Were you thinking about adding a menu, or just adding a "Phame Blog" / "Phame Post" panel type?

epriestley added a comment.Feb 2 2016, 11:12 PM

(Menu is medium-difficulty, self-contained panel types are medium-high.)

chad added a comment.Feb 2 2016, 11:17 PM

don't mind me, i'll go play in Photoshop

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
phame/
controller/
39 lines
webroot/
rsrc/
css/
application/
base/
6 lines
phame/
30 lines

Diff 36624

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phame/controller/PhameHomeController.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
Phabricator · Built by Phacility