Differential D15143

Make PHUITags not break/wrap
ClosedPublic
Actions

Authored by chad on Jan 30 2016, 3:11 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T10245: Fix Project tag icon/titles somehow from breaking

Commits

Restricted Diffusion Commit
rPce30f8c88bf6: Make PHUITags not break/wrap

Summary

Currently these break at the icon and any whitespace, instead force them to notwrap and stack the display if there are too many large tags. I think we're much more resilient CSS wise now I can't find any hairy edge cases.

Test Plan

Try to break tags in 50/50 dashboard layouts like Wikimedia

Diff Detail

Repository

rP Phabricator

Branch

arcpatch-D15143

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10412
Build 12717: Run Core Tests
Build 12716: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36564.Jan 30 2016, 3:11 AM

chad retitled this revision from to Make PHUITags not break/wrap.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 30 2016, 3:11 AM

chad added a task: T10245: Fix Project tag icon/titles somehow from breaking.Jan 30 2016, 3:12 AM

chad edited the test plan for this revision. (Show Details)Jan 30 2016, 3:14 AM

celerity

epriestley accepted this revision.Jan 31 2016, 8:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 31 2016, 8:07 PM

Closed by commit rPce30f8c88bf6: Make PHUITags not break/wrap (authored by chad, committed by chad). · Explain WhyJan 31 2016, 8:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-tag-view.css

3 lines

Diff 36570

View Options

resources/celerity/map.php