Differential D15143

Make PHUITags not break/wrap
ClosedPublic
Actions

Authored by chad on Jan 30 2016, 3:11 AM.

Tags

None

Referenced Files

	F19108378: D15143.diff
	Mon, Dec 8, 5:31 PM

	F19082818: D15143.id.diff
	Tue, Dec 2, 12:25 PM

	F19032270: D15143.id.diff
	Tue, Nov 25, 5:47 AM

	F19030968: D15143.diff
	Mon, Nov 24, 10:58 PM

	F18984875: D15143.diff
	Nov 17 2025, 12:47 PM

	F18851644: D15143.id36573.diff
	Oct 31 2025, 2:43 AM

	F18851384: D15143.id36570.diff
	Oct 31 2025, 12:39 AM

	F18849518: D15143.id36564.diff
	Oct 30 2025, 10:26 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T10245: Fix Project tag icon/titles somehow from breaking

Commits

Restricted Diffusion Commit
rPce30f8c88bf6: Make PHUITags not break/wrap

Summary

Currently these break at the icon and any whitespace, instead force them to notwrap and stack the display if there are too many large tags. I think we're much more resilient CSS wise now I can't find any hairy edge cases.

Test Plan

Try to break tags in 50/50 dashboard layouts like Wikimedia

pasted_file (623×492 px, 122 KB)

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10405
Build 12707: Run Core Tests
Build 12706: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	167 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 304 Passed)

Event Timeline

chad updated this revision to Diff 36564.Jan 30 2016, 3:11 AM

chad retitled this revision from to Make PHUITags not break/wrap.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 30 2016, 3:11 AM

chad added a task: T10245: Fix Project tag icon/titles somehow from breaking.Jan 30 2016, 3:12 AM

chad edited the test plan for this revision. (Show Details)Jan 30 2016, 3:14 AM

celerity

epriestley accepted this revision.Jan 31 2016, 8:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 31 2016, 8:07 PM

Closed by commit rPce30f8c88bf6: Make PHUITags not break/wrap (authored by chad, committed by chad). · Explain WhyJan 31 2016, 8:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

css/

phui/

phui-tag-view.css

3 lines

Diff 36564

webroot/rsrc/css/phui/phui-tag-view.css

Loading...