Details
Details
- Reviewers
chad - Maniphest Tasks
- T9969: Differential 1-up render doesn't trigger on iOS
T10229: In iOS Safari, buttons must be tapped twice to fire. - Commits
- Restricted Diffusion Commit
rPdbf1d0d7210f: Improve reliability of detecting small devices when loading Differential…
I can reproduce this by, e.g., reloading a lot on an iPhone 4s in iOS Simulator running iOS 9.2. Sometimes it picks 2-up. I added logging to show that the viewport dimension read was the issue.
After this change, it always selects 1-up (window.screen.availWidth is defined and sensible on the device).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- doubletouch1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10379 Build 12664: Run Core Tests Build 12663: arc lint + arc unit