Page MenuHomePhabricator
Differential D15113

Prevent "Manage" profile menu items from being hidden
ClosedPublic
Actions

Authored by epriestley on Jan 25 2016, 11:23 AM.
Tags
None
Referenced Files
F15507697: D15113.diff
Tue, Apr 15, 10:00 PM
F15488254: D15113.id36493.diff
Thu, Apr 10, 8:42 PM
F15488146: D15113.id36492.diff
Thu, Apr 10, 7:51 PM
F15483969: D15113.id.diff
Wed, Apr 9, 3:29 PM
F15479968: D15113.diff
Tue, Apr 8, 10:32 AM
F15444225: D15113.id.diff
Thu, Mar 27, 8:34 AM
F15416128: D15113.id36492.diff
Thu, Mar 20, 9:25 AM
F15415038: D15113.id.diff
Thu, Mar 20, 3:40 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10054: Define product direction for Project/Profile UIs
Commits
Restricted Diffusion Commit
rPc11c7f29009a: Prevent "Manage" profile menu items from being hidden
Summary

Ref T10054. Prevent users from removing this item and locking themselves out of the system unless they can guess the URI.

Test Plan

Tried to disable "Manage", wasn't permitted to.

Diff Detail

Repository
rP Phabricator
Branch
noremove1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10332
Build 12591: Run Core Tests
Build 12590: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36492.Jan 25 2016, 11:23 AM
epriestley retitled this revision from to Prevent "Manage" profile menu items from being hidden.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10054: Define product direction for Project/Profile UIs.
chad accepted this revision.Jan 25 2016, 2:41 PM
chad edited edge metadata.

Thanks for updating the documentation.

This revision is now accepted and ready to land.Jan 25 2016, 2:41 PM
Closed by commit rPc11c7f29009a: Prevent "Manage" profile menu items from being hidden (authored by epriestley, committed by epriestley). · Explain WhyJan 25 2016, 2:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
profilepanel/
5 lines
project/
profilepanel/
5 lines
search/
engine/
11 lines
profilepanel/
5 lines
storage/
7 lines
docs/
user/
userguide/
12 lines

Diff 36492

View Options

src/applications/people/profilepanel/PhabricatorPeopleManageProfilePanel.php

Loading...
View Options

src/applications/project/profilepanel/PhabricatorProjectManageProfilePanel.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...
View Options

src/applications/search/profilepanel/PhabricatorProfilePanel.php

Loading...
View Options

src/applications/search/storage/PhabricatorProfilePanelConfiguration.php

Loading...
View Options

src/docs/user/userguide/profile_menu.diviner

Loading...
Phabricator · Built by Phacility