Page MenuHomePhabricator
Differential D15106

Add setProfileHeader to PHUIHeaderView for reuse
ClosedPublic
Actions

Authored by chad on Jan 24 2016, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 6:17 AM
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Fri, Dec 13, 9:42 AM
Unknown Object (File)
Tue, Dec 10, 1:12 PM
Unknown Object (File)
Tue, Dec 10, 1:11 PM
Unknown Object (File)
Tue, Dec 10, 1:11 PM
Unknown Object (File)
Fri, Dec 6, 5:43 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPbba14118c793: Add setProfileHeader to PHUIHeaderView for reuse
Summary

Moves some profile css into PHUI, cleans up mobile view and desktop spacing.

Test Plan

Test Project at desktop and mobile breakpoints.

Diff Detail

Repository
rP Phabricator
Branch
phui-profile-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10306
Build 12554: Run Core Tests
Build 12553: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36468.Jan 24 2016, 4:28 PM
chad retitled this revision from to Add setProfileHeader to PHUIHeaderView for reuse.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJan 24 2016, 4:28 PM
chad updated this revision to Diff 36469.Jan 24 2016, 4:30 PM
  • revert atom stuff
chad updated this revision to Diff 36470.Jan 24 2016, 4:35 PM
  • revert workboard
epriestley accepted this revision.Jan 24 2016, 4:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2016, 4:53 PM
Closed by commit rPbba14118c793: Add setProfileHeader to PHUIHeaderView for reuse (authored by chad, committed by chad). · Explain WhyJan 24 2016, 5:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
diviner/
controller/
4 lines
project/
controller/
1 line
10 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
application/
project/
36 lines
phui/
37 lines

Diff 36468

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/application/project/project-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility