Differential D15083

More profile nav updates
ClosedPublic
Actions

Authored by chad on Jan 22 2016, 2:39 AM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP1eec74712352: More profile nav updates

Summary

Sets the edit, collapse icons back in the footer, also adds basic transitions.

Test Plan

lots of clicking, safari and chrome

Diff Detail

Repository

rP Phabricator

Branch

sidenav-2 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10253
Build 12471: Run Core Tests
Build 12470: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36417.Jan 22 2016, 2:39 AM

chad retitled this revision from to More profile nav updates.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 22 2016, 2:39 AM

chad edited the test plan for this revision. (Show Details)Jan 22 2016, 2:52 AM

better specificity

better specificity
transition polish

epriestley accepted this revision.Jan 22 2016, 3:33 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 3:33 AM

Closed by commit rP1eec74712352: More profile nav updates (authored by chad, committed by chad). · Explain WhyJan 22 2016, 3:39 AM

This revision was automatically updated to reflect the committed changes.

its feels ok, but im sure there will be more updates as we go along

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-profile-menu.css

67 lines

Diff 36417

View Options

resources/celerity/map.php