Page MenuHomePhabricator
Differential D15082

Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 2:04 PM
Unknown Object (File)
Sun, Feb 9, 12:33 AM
Unknown Object (File)
Sun, Feb 9, 12:33 AM
Unknown Object (File)
Sun, Feb 9, 12:33 AM
Unknown Object (File)
Fri, Jan 31, 7:00 AM
Unknown Object (File)
Wed, Jan 29, 7:43 AM
Unknown Object (File)
Fri, Jan 24, 11:21 AM
Unknown Object (File)
Fri, Jan 24, 11:21 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10196: Toggling the conpherence sidebar breaks project Open Task view
Commits
Restricted Diffusion Commit
rP6ea9aa39a08a: Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch
Summary

Fixes T10196. This is a weird interaction and this might not be the best long-term fix, but just get it working OK for now.

General problem is that Quicksand doesn't currently use GET for requests. This is a very unusual case where the method is relevant. In the future, I might change Quicksand to use GET.

Test Plan

Clicked "Open Tasks" with Quicksand active, got a results list.

Diff Detail

Repository
rP Phabricator
Branch
quick1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10251
Build 12468: Run Core Tests
Build 12467: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36415.Jan 22 2016, 12:23 AM
epriestley retitled this revision from to Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10196: Toggling the conpherence sidebar breaks project Open Task view.
chad accepted this revision.Jan 22 2016, 12:29 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2016, 12:29 AM
Closed by commit rP6ea9aa39a08a: Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 12:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
2 lines

Diff 36415

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
Phabricator · Built by Phacility