Page MenuHomePhabricator
Differential D15074

Remove unused `appIcon` from PHUIListItemView
ClosedPublic
Actions

Authored by epriestley on Jan 21 2016, 6:06 PM.
Tags
None
Referenced Files
F14025487: D15074.diff
Thu, Nov 7, 6:23 PM
F14010809: D15074.id36398.diff
Thu, Oct 31, 12:35 PM
F14010808: D15074.id.diff
Thu, Oct 31, 12:35 PM
F14010805: D15074.id36399.diff
Thu, Oct 31, 12:33 PM
F14010024: D15074.diff
Thu, Oct 31, 3:14 AM
F13997086: D15074.diff
Thu, Oct 24, 2:02 AM
F13974846: D15074.diff
Fri, Oct 18, 7:38 AM
F13966927: D15074.id36399.diff
Wed, Oct 16, 10:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP7d1809f9352f: Remove unused `appIcon` from PHUIListItemView
Summary

This is unused and there's no way to even set it. Pretty sure it died a while ago when we switched app icons to FontAwesome.

Test Plan

Grepped for appIcon, found no related hits. Browsed some pages.

Diff Detail

Repository
rP Phabricator
Branch
pmenu2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10234
Build 12442: Run Core Tests
Build 12441: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36398.Jan 21 2016, 6:06 PM
epriestley retitled this revision from to Remove unused `appIcon` from PHUIListItemView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jan 21 2016, 6:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 21 2016, 6:07 PM
Closed by commit rP7d1809f9352f: Remove unused `appIcon` from PHUIListItemView (authored by epriestley, committed by epriestley). · Explain WhyJan 21 2016, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
9 lines

Diff 36398

View Options

src/view/phui/PHUIListItemView.php

Loading...
Phabricator · Built by Phacility