Differential D15054

When publishing project transactions, load ancestor members
ClosedPublic
Actions

Authored by epriestley on Jan 19 2016, 5:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 1:08 AM

	Unknown Object (File)
	Wed, Dec 18, 1:07 AM

	Unknown Object (File)
	Sun, Dec 15, 10:45 AM

	Unknown Object (File)
	Wed, Dec 4, 1:27 PM

	Unknown Object (File)
	Thu, Nov 28, 3:36 PM

	Unknown Object (File)
	Mon, Nov 25, 7:10 AM

	Unknown Object (File)
	Nov 18 2024, 9:55 AM

	Unknown Object (File)
	Nov 5 2024, 10:11 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10010: Implement Subprojects
T10107: (PhabricatorDataNotAttachedException) Attempting to access attached data on PhabricatorProject, but the data is not actually attached.

Commits

Restricted Diffusion Commit
rPc51752b4aa79: When publishing project transactions, load ancestor members

Summary

Ref T10010. Fixes T10107. When we publish a transaction about a project, we perform visibility checks for many different users. We need to know all of the ancestors' members to perform these checks.

Test Plan

Before patch: when updating a subproject, daemons fatal trying to publish things because they can not test visibility of parent projects.
After patch: daemons successfully publish subproject updates.
Also added a unit test.

Diff Detail

Repository

Branch

pmenu2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10190
Build 12376: Run Core Tests
Build 12375: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36355.Jan 19 2016, 5:53 PM

epriestley retitled this revision from to When publishing project transactions, load ancestor members.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10107: (PhabricatorDataNotAttachedException) Attempting to access attached data on PhabricatorProject, but the data is not actually attached., T10010: Implement Subprojects.

chad accepted this revision.Jan 19 2016, 5:59 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 19 2016, 5:59 PM

Closed by commit rPc51752b4aa79: When publishing project transactions, load ancestor members (authored by epriestley, committed by epriestley). · Explain WhyJan 19 2016, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

__tests__/

PhabricatorProjectCoreTestCase.php

69 lines

editor/

PhabricatorProjectTransactionEditor.php

2 lines

query/

PhabricatorProjectQuery.php

40 lines

Diff 36355

src/applications/project/tests/PhabricatorProjectCoreTestCase.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/query/PhabricatorProjectQuery.php

Loading...