Differential D15042

Eat right-click, etc., on autocomplete suggestion menu
ClosedPublic
Actions

Authored by epriestley on Jan 16 2016, 11:38 PM.

Details

Reviewers

chad

Maniphest Tasks

T10163: Remarkup Autocomplete Errata

Commits

Restricted Diffusion Commit
rP7ab970d1a7d3: Eat right-click, etc., on autocomplete suggestion menu

Summary

Ref T10163. If you right-click the suggestion menu, just eat it. I don't think we can really choose a different behavior reasonably, or that users have any reason to do this.

I'm leaving "clicking the header dismisses it", I think that behavior is fine and reasonable.

Test Plan

Control-clicked a suggestion menu, didn't trigger a suggestion.

Diff Detail

Repository

rP Phabricator

Branch

auto13

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10164
Build 12336: Run Core Tests
Build 12335: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36329.Jan 16 2016, 11:38 PM

epriestley retitled this revision from to Eat right-click, etc., on autocomplete suggestion menu.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10163: Remarkup Autocomplete Errata.

chad accepted this revision.Jan 16 2016, 11:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 16 2016, 11:49 PM

Closed by commit rP7ab970d1a7d3: Eat right-click, etc., on autocomplete suggestion menu (authored by epriestley, committed by epriestley). · Explain WhyJan 16 2016, 11:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

phuix/

PHUIXAutocomplete.js

8 lines

Diff 36329

View Options

resources/celerity/map.php