When the autocompleter would fall off the bottom of the screen, put it above the text instead
ClosedPublic
Actions

Authored by epriestley on Jan 16 2016, 10:02 PM.

Details

Reviewers

Maniphest Tasks

Commits

Restricted Diffusion Commit
rP849b4c765a1f: When the autocompleter would fall off the bottom of the screen, put it above…

Summary

Ref T10163. In cases like Conpherence, the autocompleter can currently render off the bottom of the screen. Put it above if it would be offscreen.

Test Plan

Screen Shot 2016-01-16 at 1.59.44 PM.png (379×408 px, 30 KB)

Diff Detail

Repository

rP Phabricator

Branch

auto9

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10154
Build 12322: Run Core Tests
Build 12321: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36319.Jan 16 2016, 10:02 PM

epriestley retitled this revision from to When the autocompleter would fall off the bottom of the screen, put it above the text instead.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10163: Remarkup Autocomplete Errata.

chad accepted this revision.Jan 16 2016, 10:20 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 16 2016, 10:20 PM

Closed by commit rP849b4c765a1f: When the autocompleter would fall off the bottom of the screen, put it above… (authored by epriestley, committed by epriestley). · Explain WhyJan 16 2016, 10:38 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10163: Remarkup Autocomplete Errata.Jan 16 2016, 10:49 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

phuix/

PHUIXAutocomplete.js

22 lines

Diff 36319

View Options

resources/celerity/map.php