Page MenuHomePhabricator

Improve autocomplete behavior when typing ordered lists
ClosedPublic

Authored by epriestley on Jan 15 2016, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 6:54 PM
Unknown Object (File)
Aug 22 2024, 8:01 AM
Unknown Object (File)
Aug 18 2024, 8:32 PM
Unknown Object (File)
Aug 18 2024, 2:12 AM
Unknown Object (File)
Aug 14 2024, 9:48 PM
Unknown Object (File)
Aug 11 2024, 2:01 AM
Unknown Object (File)
Aug 9 2024, 6:27 AM
Unknown Object (File)
Aug 7 2024, 9:39 AM
Subscribers
None

Details

Summary

Ref T10163.

  • If a user types an autocomplete character ("@" or "#") and then a space, deactivate immediately (probably an ordered list).
  • If a user types an autocomplete character indented on a line with no other prior text, don't activate (probably an ordered list or code block).
Test Plan

Typed:

  • # , saw immediate deactivation.
  • #, saw no activation in the first place.
  • #x, saw activation.
  • asdf #x, saw activation.

Diff Detail

Repository
rP Phabricator
Branch
auto4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10147
Build 12310: Run Core Tests
Build 12309: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve autocomplete behavior when typing ordered lists.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.