Page MenuHomePhabricator

Improve autocomplete behavior when typing ordered lists
ClosedPublic

Authored by epriestley on Jan 15 2016, 7:13 PM.
Tags
None
Referenced Files
F15472354: D15033.diff
Sat, Apr 5, 12:47 PM
F15453622: D15033.id36313.diff
Sat, Mar 29, 1:10 PM
F15453246: D15033.id36312.diff
Sat, Mar 29, 10:26 AM
F15451491: D15033.id.diff
Fri, Mar 28, 10:22 PM
F15445564: D15033.diff
Thu, Mar 27, 2:37 PM
F15414990: D15033.id36312.diff
Thu, Mar 20, 3:25 AM
F15414950: D15033.diff
Thu, Mar 20, 3:14 AM
F15339337: D15033.diff
Mar 9 2025, 2:42 PM
Subscribers
None

Details

Summary

Ref T10163.

  • If a user types an autocomplete character ("@" or "#") and then a space, deactivate immediately (probably an ordered list).
  • If a user types an autocomplete character indented on a line with no other prior text, don't activate (probably an ordered list or code block).
Test Plan

Typed:

  • # , saw immediate deactivation.
  • #, saw no activation in the first place.
  • #x, saw activation.
  • asdf #x, saw activation.

Diff Detail

Repository
rP Phabricator
Branch
auto4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10147
Build 12310: Run Core Tests
Build 12309: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve autocomplete behavior when typing ordered lists.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.