Page MenuHomePhabricator
Differential D15015

Remove newFromMenu() from SideNav
ClosedPublic
Actions

Authored by epriestley on Jan 13 2016, 11:59 PM.
Tags
None
Referenced Files
F18216528: D15015.diff
Tue, Aug 19, 7:46 AM
F18102528: D15015.id36267.diff
Sat, Aug 9, 9:28 PM
F18085634: D15015.id.diff
Tue, Aug 5, 7:20 PM
F17859566: D15015.id36267.diff
Sun, Jul 27, 8:52 PM
F17838751: D15015.diff
Sat, Jul 26, 7:04 PM
Unknown Object (File)
Jun 3 2025, 12:56 AM
Unknown Object (File)
Jun 1 2025, 12:21 PM
Unknown Object (File)
Jun 1 2025, 2:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10054: Define product direction for Project/Profile UIs
Commits
Restricted Diffusion Commit
rP3f439e25bc58: Remove newFromMenu() from SideNav
Summary

Ref T10054. Just simplifying this a bit before I start laying in the new profile menus.

Test Plan
  • Viewed Diviner on desktop and checked the mobile menu.
  • Viewed Files on desktop and checked the mobile menu.

Diff Detail

Repository
rP Phabricator
Branch
pmenu1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10101
Build 12241: Run Core Tests
Build 12240: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36267.Jan 13 2016, 11:59 PM
epriestley retitled this revision from to Remove newFromMenu() from SideNav.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10054: Define product direction for Project/Profile UIs.
chad accepted this revision.Jan 14 2016, 12:34 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2016, 12:34 AM
Closed by commit rP3f439e25bc58: Remove newFromMenu() from SideNav (authored by epriestley, committed by epriestley). · Explain WhyJan 14 2016, 1:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
application/
2 lines
controller/
11 lines
14 lines
query/
2 lines
files/
application/
2 lines
controller/
23 lines
10 lines
view/
layout/
7 lines

Diff 36267

View Options

src/applications/diviner/application/PhabricatorDivinerApplication.php

Loading...
View Options

src/applications/diviner/controller/DivinerAtomListController.php

Loading...
View Options

src/applications/diviner/controller/DivinerController.php

Loading...
View Options

src/applications/diviner/query/DivinerAtomSearchEngine.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileListController.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
Phabricator · Built by Phacility