Page MenuHomePhabricator
Differential D15003

Don't return any results for viewerprojects() if the viewer is in no projects
ClosedPublic
Actions

Authored by epriestley on Jan 12 2016, 2:11 PM.
Tags
None
Referenced Files
F14351679: D15003.id36243.diff
Thu, Dec 19, 9:25 AM
Unknown Object (File)
Tue, Dec 17, 7:25 AM
Unknown Object (File)
Tue, Dec 17, 6:27 AM
Unknown Object (File)
Mon, Dec 16, 1:30 AM
Unknown Object (File)
Fri, Dec 13, 3:53 PM
Unknown Object (File)
Mon, Dec 2, 1:29 AM
Unknown Object (File)
Wed, Nov 27, 12:52 PM
Unknown Object (File)
Sat, Nov 23, 2:37 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10135: Current Viewer's Projects when NO projects joined
Commits
Restricted Diffusion Commit
rPdd21761df9e8: Don't return any results for viewerprojects() if the viewer is in no projects
Summary

Fixes T10135. When the viewer is a member of no projects, specify the constraint type as a new "EMPTY" type.

When a query has an "EMPTY" constraint, fail fast with no results.

Test Plan
  • Viewed a viewerprojects() query result set as a user in no projects.
    • Before patch: got a lot of hits. After patch: no hits.
  • Viewed a normal result set, no changes.

Diff Detail

Repository
rP Phabricator
Branch
noproject1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10077
Build 12204: Run Core Tests
Build 12203: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36243.Jan 12 2016, 2:11 PM
epriestley retitled this revision from to Don't return any results for viewerprojects() if the viewer is in no projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10135: Current Viewer's Projects when NO projects joined.
chad accepted this revision.Jan 12 2016, 3:00 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2016, 3:00 PM
Closed by commit rPdd21761df9e8: Don't return any results for viewerprojects() if the viewer is in no projects (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
typeahead/
12 lines
infrastructure/
query/
constraint/
1 line
policy/
10 lines

Diff 36243

View Options

src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php

Loading...
View Options

src/infrastructure/query/constraint/PhabricatorQueryConstraint.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility