Page MenuHomePhabricator

If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire file
ClosedPublic

Authored by epriestley on Jan 12 2016, 1:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:47 PM
Unknown Object (File)
Fri, Nov 22, 5:09 PM
Unknown Object (File)
Sat, Nov 9, 11:11 AM
Unknown Object (File)
Oct 24 2024, 6:44 PM
Unknown Object (File)
Oct 24 2024, 2:33 AM
Unknown Object (File)
Oct 17 2024, 2:27 AM
Unknown Object (File)
Oct 16 2024, 12:47 AM
Unknown Object (File)
Oct 11 2024, 6:33 AM
Subscribers
None

Details

Summary

Fixes T10124.

Test Plan

Added this "linter" to .arclint:

"thing": {
  "type": "script-and-regex",
  "script-and-regex.script": "echo every file is very bad #",
  "script-and-regex.regex": "/^(?P<message>.*)/"
}

...to produce this diff. Also made a variant of it which matches lines to make sure that still works.

Diff Detail

Repository
rARC Arcanist
Branch
srex1
Lint
Lint Errors
SeverityLocationCodeMessage
Error.arclint:S&RXLint
Errorsrc/lint/linter/ArcanistScriptAndRegexLinter.php:S&RXLint
Unit
Tests Passed
Build Status
Buildable 10070
Build 12192: Run Core Tests
Build 12191: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire file.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/lint/linter/ArcanistScriptAndRegexLinter.php
1

I feel like there should be something spinning here.

This revision is now accepted and ready to land.Jan 12 2016, 1:28 AM
epriestley edited edge metadata.
  • Remove example changes to .arclint now that we've all had a right jolly giggle.
This revision was automatically updated to reflect the committed changes.