Page MenuHomePhabricator
Differential D14995

Parse and display commit authorship date in Git in Diffusion
ClosedPublic
Actions

Authored by epriestley on Jan 11 2016, 1:20 PM.
Tags
None
Referenced Files
F14037034: D14995.id36218.diff
Sun, Nov 10, 1:33 PM
F14036837: D14995.diff
Sun, Nov 10, 12:24 PM
F14024684: D14995.diff
Thu, Nov 7, 11:33 AM
F13975354: D14995.diff
Fri, Oct 18, 9:48 AM
F13967126: D14995.id.diff
Wed, Oct 16, 11:52 AM
F13962506: D14995.id36217.diff
Tue, Oct 15, 10:30 AM
F13955732: D14995.id36218.diff
Mon, Oct 14, 2:45 AM
Unknown Object (File)
Oct 8 2024, 10:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8826: Add authored date to commit properties
Commits
Restricted Diffusion Commit
rPa061bd2d09c2: Parse and display commit authorship date in Git in Diffusion
Summary

Fixes T8826. Git tracks an "author date", which may be different from the "committed date". We don't currently extract/show this; do so.

Test Plan

Screen Shot 2016-01-11 at 5.18.59 AM.png (69×351 px, 16 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36217.Jan 11 2016, 1:20 PM
epriestley updated this revision to Diff 36218.
epriestley retitled this revision from to Parse and display commit authorship date in Git in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8826: Add authored date to commit properties.
  • Also remove the TODO comment that this specifically addresses.
epriestley mentioned this in T8826: Add authored date to commit properties.Jan 11 2016, 5:21 PM
chad accepted this revision.Jan 11 2016, 5:30 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 5:30 PM
Closed by commit rPa061bd2d09c2: Parse and display commit authorship date in Git in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2016, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
2 lines
controller/
8 lines
data/
11 lines
query/
lowlevel/
10 lines
repository/
worker/
commitmessageparser/
1 line

Diff 36226

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/data/DiffusionCommitRef.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility