Page MenuHomePhabricator
Differential D14994

Show repositories in global autocomplete dropdown
ClosedPublic
Actions

Authored by epriestley on Jan 11 2016, 1:09 PM.
Tags
None
Referenced Files
F14881654: D14994.id36225.diff
Sun, Feb 9, 12:25 AM
F14881653: D14994.id36216.diff
Sun, Feb 9, 12:25 AM
F14881652: D14994.id.diff
Sun, Feb 9, 12:25 AM
F14881650: D14994.diff
Sun, Feb 9, 12:25 AM
Unknown Object (File)
Sun, Jan 26, 7:16 PM
Unknown Object (File)
Fri, Jan 24, 11:07 AM
Unknown Object (File)
Fri, Jan 24, 11:07 AM
Unknown Object (File)
Fri, Jan 24, 11:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9523: Make search autocomplete show repository names
Commits
Restricted Diffusion Commit
rP9fb929dff3f0: Show repositories in global autocomplete dropdown
Summary

Fixes T9523.

Test Plan

Screen Shot 2016-01-11 at 5.08.13 AM.png (132×400 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
runique5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10050
Build 12164: Run Core Tests
Build 12163: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36216.Jan 11 2016, 1:09 PM
epriestley retitled this revision from to Show repositories in global autocomplete dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9523: Make search autocomplete show repository names.
chad accepted this revision.Jan 11 2016, 5:22 PM
chad edited edge metadata.
chad added inline comments.
src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php
13

https://octicons.github.com/ is fairly tempting here, since the set is specifically tailored to similar software needs.

This revision is now accepted and ready to land.Jan 11 2016, 5:22 PM
epriestley added a comment.Jan 11 2016, 5:31 PM

They have a couple of cool ones (I like the telescope and paint bucket) but it looks like we wouldn't really get that many new ones.

GitHub's repository icon ("book with bookmark") doesn't feel that great to me on its own and is very GitHub-brand-ish to me (e.g., Bitbucket and even GitLab do not use the same icon) so I'd be hesitant to use it in Phabricator.

Closed by commit rP9fb929dff3f0: Show repositories in global autocomplete dropdown (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2016, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
src/
applications/
diffusion/
typeahead/
22 lines
repository/
phid/
2 lines
query/
5 lines
search/
typeahead/
1 line
webroot/
rsrc/
js/
core/
3 lines

Diff 36216

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/search/typeahead/PhabricatorSearchDatasource.php

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
Phabricator · Built by Phacility