Page MenuHomePhabricator

Enforce sensible, unique clone/checkout names for repositories
ClosedPublic

Authored by epriestley on Jan 10 2016, 7:18 PM.
Tags
None
Referenced Files
F13251859: D14986.diff
Sat, May 25, 12:49 AM
F13249075: D14986.diff
Fri, May 24, 6:29 AM
F13226706: D14986.diff
Sun, May 19, 10:42 PM
F13203366: D14986.diff
Tue, May 14, 11:41 PM
F13185731: D14986.diff
Sat, May 11, 3:10 AM
F13184876: D14986.diff
Sat, May 11, 1:13 AM
Unknown Object (File)
Tue, May 7, 5:38 AM
Unknown Object (File)
Sat, May 4, 12:28 PM
Subscribers
None

Details

Summary

Fixes T7938.

  • Primarily, users can currently shoot themselves in the foot by putting ../../etc/passwd and other similar nonsense in these fields (this is not dangerous, but also does not work). Require sensible names.
  • Enforce uniqueness so these names can be used in URIs and as identifiers in the future.
  • (This doesn't start actually using them for anything fancy yet.)
Test Plan
  • Gave several repositories clone names: a valid name, two duplicate names, an invalid, name, some with no names.
  • Ran migrations.
  • Got clean conversion for valid names, appropriate errors for invalid/duplicate names.

Diff Detail

Repository
rP Phabricator
Branch
runique1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10039
Build 12144: Run Core Tests
Build 12143: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Enforce sensible, unique clone/checkout names for repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

Nice tests!

This revision is now accepted and ready to land.Jan 11 2016, 1:08 AM
This revision was automatically updated to reflect the committed changes.