Differential D14985

Link "continue" action to confirm dialog in bulk jobs that are unconfirmed
ClosedPublic
Actions

Authored by epriestley on Jan 10 2016, 6:06 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP96b1665eaa12: Link "continue" action to confirm dialog in bulk jobs that are unconfirmed

Summary

See Q266.

Test Plan

Created a bulk job, clicked "Details" instead of "Confirm", clicked "Continue" to get back to confirmation dialog.

Diff Detail

Repository

rP Phabricator

Branch

bulk1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10037
Build 12141: Run Core Tests
Build 12140: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36203.Jan 10 2016, 6:06 PM

epriestley retitled this revision from to Link "continue" action to confirm dialog in bulk jobs that are unconfirmed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley mentioned this in Q266: How can I confirm a bulk job? (Answer 298).Jan 10 2016, 6:07 PM

chad accepted this revision.Jan 10 2016, 6:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 10 2016, 6:15 PM

Closed by commit rP96b1665eaa12: Link "continue" action to confirm dialog in bulk jobs that are unconfirmed (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2016, 6:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

controller/

PhabricatorDaemonBulkJobViewController.php

8 lines

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerBulkJob.php

4 lines

Diff 36203

View Options

src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php