Page MenuHomePhabricator
Differential D14981

Modernize `bin/files migrate` and fix behavior on chunk engines
ClosedPublic
Actions

Authored by epriestley on Jan 9 2016, 5:49 PM.
Tags
None
Referenced Files
F14063214: D14981.diff
Mon, Nov 18, 5:20 PM
F14051001: D14981.diff
Thu, Nov 14, 9:53 PM
F14041034: D14981.diff
Mon, Nov 11, 3:31 PM
F14023206: D14981.diff
Thu, Nov 7, 12:03 AM
F13993086: D14981.id36189.diff
Tue, Oct 22, 8:35 PM
F13981015: D14981.id36190.diff
Oct 19 2024, 1:49 PM
F13967761: D14981.diff
Oct 16 2024, 3:46 PM
Unknown Object (File)
Oct 13 2024, 10:21 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9828: Make migrating files less scary
Commits
Restricted Diffusion Commit
rP67ac356b0327: Modernize `bin/files migrate` and fix behavior on chunk engines
Summary

Ref T9828. Mostly just does a minor modernization pass, but also doesn't migrate chunked files since it's not meaningful (they don't have data, directly).

Test Plan

Ran bin/files migrate with various flags. Migrated S3 -> Blob and Blob -> S3.

Diff Detail

Repository
rP Phabricator
Branch
files1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10023
Build 12120: Run Core Tests
Build 12119: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36189.Jan 9 2016, 5:49 PM
epriestley retitled this revision from to Modernize `bin/files migrate` and fix behavior on chunk engines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9828: Make migrating files less scary.
chad accepted this revision.Jan 9 2016, 6:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2016, 6:49 PM
Closed by commit rP67ac356b0327: Modernize `bin/files migrate` and fix behavior on chunk engines (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2016, 7:46 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9828: Make migrating files less scary.Jan 10 2016, 4:13 PM

Revision Contents
Changeset List

PathSize
src/
applications/
files/
management/
96 lines

Diff 36189

View Options

src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php

Loading...
Phabricator · Built by Phacility