Page MenuHomePhabricator
Differential D14974

Improve rendering of commit branching graph
ClosedPublic
Actions

Authored by epriestley on Jan 8 2016, 7:45 PM.
Tags
None
Referenced Files
F13983736: D14974.diff
Sun, Oct 20, 8:23 AM
F13972253: D14974.id.diff
Thu, Oct 17, 5:59 PM
Unknown Object (File)
Oct 1 2024, 10:07 PM
Unknown Object (File)
Sep 19 2024, 9:45 AM
Unknown Object (File)
Sep 19 2024, 9:44 AM
Unknown Object (File)
Sep 19 2024, 9:42 AM
Unknown Object (File)
Sep 18 2024, 3:52 AM
Unknown Object (File)
Sep 12 2024, 1:20 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9323: First commit in repository's history visual 'dot line' shouldn't have red line before
Commits
Restricted Diffusion Commit
rPc7520cd9f26d: Improve rendering of commit branching graph
Summary

Fixes T9323. Two minor fixes:

  • On the first commit, don't render a downward line.
  • Clean up a 1px spacing issue that had cropped up a while ago when we added icons or something, I think.
Test Plan

Before:

Screen Shot 2016-01-08 at 11.41.55 AM.png (228×228 px, 21 KB)

After:

Screen Shot 2016-01-08 at 11.42.05 AM.png (230×261 px, 26 KB)

Diff Detail

Repository
rP Phabricator
Branch
ctail
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10008
Build 12098: Run Core Tests
Build 12097: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36176.Jan 8 2016, 7:45 PM
epriestley retitled this revision from to Improve rendering of commit branching graph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9323: First commit in repository's history visual 'dot line' shouldn't have red line before.
chad accepted this revision.Jan 8 2016, 7:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 7:47 PM
epriestley added a comment.Jan 8 2016, 7:47 PM

This technically does the wrong thing for repositories with exactly one commit, I guess.

epriestley updated this revision to Diff 36177.Jan 8 2016, 7:51 PM
epriestley edited edge metadata.
  • Fix rendering for repositories with exactly one commit.
Closed by commit rPc7520cd9f26d: Improve rendering of commit branching graph (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2016, 7:52 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jan 8 2016, 7:52 PM

PRIDE IN CRAFTSMANSHIP

chad added a comment.Jan 8 2016, 7:53 PM

itsbeautiful

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
diffusion/
controller/
1 line
view/
16 lines
view/
phui/
4 lines
webroot/
rsrc/
js/
application/
diffusion/
20 lines

Diff 36177

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/view/phui/PHUIPagerView.php

Loading...
View Options

webroot/rsrc/js/application/diffusion/behavior-commit-graph.js

Loading...
Phabricator · Built by Phacility