Fix badges edit form
ClosedPublic
Actions

Authored by chad on Jan 6 2016, 8:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 25, 6:51 AM

	Unknown Object (File)
	Fri, May 9, 9:13 PM

	Unknown Object (File)
	Apr 23 2025, 1:20 PM

	Unknown Object (File)
	Apr 23 2025, 11:13 AM

	Unknown Object (File)
	Apr 23 2025, 6:00 AM

	Unknown Object (File)
	Apr 22 2025, 5:50 PM

	Unknown Object (File)
	Apr 13 2025, 1:01 PM

	Unknown Object (File)
	Apr 10 2025, 7:28 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPab27af9fc608: Fix badges edit form

Summary

Make sure to subclass the right controller on badges.

Test Plan

arc liberate, make a custom badges edit form.

Diff Detail

Repository

rP Phabricator

Branch

derp-badges (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9968
Build 12041: Run Core Tests
Build 12040: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36143.Jan 6 2016, 8:07 PM

chad retitled this revision from to Fix badges edit form.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 6 2016, 8:07 PM

epriestley accepted this revision.Jan 6 2016, 9:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2016, 9:13 PM

Closed by commit rPab27af9fc608: Fix badges edit form (authored by chad, committed by chad). · Explain WhyJan 6 2016, 9:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

badges/

controller/

PhabricatorBadgesEditController.php

3 lines

Diff 36143

View Options

src/__phutil_library_map__.php